Changelog

The note entity JSON nests blocks at content.content (PageDocument has

{ "type": "doc", "content": [...blocks...] }), not at content directly.

The previous fix checked content.ValueKind == Array which was Object

(the PageDocument), so it fell through to the else branch and returned

without finding any dataset references.

Now drills content → content.content to find the block array.

AppendEmbeddedDatasetContentAsync expected note content to be a JSON

string and scanned for "dataset_id" via text search. Content is actually

a JSON array of typed block objects, so the method bailed at the

type check and never found any dataset references.

Rewritten to:

• Parse content as a block array, iterating table/chart blocks
• Extract dataset_id (Data plugin datasets) and provider_plugin_id +

provider_query_key (cross-plugin queries from Tasks, Contacts, etc.)

• Query via IPluginDataSourceProvider using the correct provider for

each backing mode

• Fetch first 20 rows and inject columns + data into Duncan's context
• Legacy string fallback preserved for older content formats
• Capped at 3 embedded data sources per note to stay within token limits

Duncan was scoped as "dedicated exclusively to the PrivStack ecosystem"

which refused general-knowledge questions. Cloud models use the user's

own API key, so there's no reason to restrict what they can talk about.

Updated cloud system prompt to:

• Explicitly allow any topic (general knowledge, weather, creative, etc.)
• Ask for location context (zip code) when needed for location-dependent

questions like weather, if not already in memory

• Use memory-stored location when available

When a vault blob no longer exists (data wipe, profile change), the

VaultBlobDelete call throws NotFound, which aborted the entire delete

handler — leaving the stale key hint in settings and the entry in the

Saved Keys list with no way to remove it.

Now catches the VaultBlobDelete failure independently and still proceeds

to clean up the settings hint and cached provider key.

The previous fix (deferred recheck) was insufficient. The root issue is

that AiService.IsAvailable called provider.IsConfigured which does a

synchronous vault blob read via FFI. This can fail silently during

startup, and since IsEnabled is a plain getter with no re-notification,

Duncan stays hidden for the session.

New approach: IsAvailable for cloud providers now checks

AppSettings.AiSavedKeyHints instead of reading the vault. The key hints

are persisted in the settings JSON when a user saves an API key, so

they're available immediately at startup — no vault read needed. The

actual vault read still happens at request time via the async path in

CompleteAsync/StreamCompleteAsync, which properly handles vault unlock.

This is a UI-gating-only change. The vault-based IsConfigured check

is still used by GetProviders() (settings page) and at request time.